Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all pack versions to 1.0.0 #16564

Merged
merged 3 commits into from
May 23, 2024
Merged

Update all pack versions to 1.0.0 #16564

merged 3 commits into from
May 23, 2024

Conversation

dbartol
Copy link
Contributor

@dbartol dbartol commented May 22, 2024

This PR updates the version numbers of all of our packs to 1.0.0, in preparation for the CodeQL Packaging GA in CLI release 2.17.4.

@dbartol
Copy link
Contributor Author

dbartol commented May 22, 2024

Test run of release prep here. Everything looks good. The codeql pack release command correctly handles the manual version bump by setting the release version to the maximum of (current pack version) and (previous release version plus bump).

@aeisenberg
Copy link
Contributor

I forgot where we came down on this, but do we want to add a changelog note to each pack describing why we are bumping to 1.0.0?

@dbartol
Copy link
Contributor Author

dbartol commented May 23, 2024

Updated to add a change note to each pack explaining the bump to 1.0.0. Sample release prep here.

@dbartol dbartol marked this pull request as ready for review May 23, 2024 17:11
@dbartol dbartol requested review from a team as code owners May 23, 2024 17:11
@aeisenberg
Copy link
Contributor

Thanks. With the category: breaking metadata, would this make the next release step bump all versions to 2.0.0?

@dbartol
Copy link
Contributor Author

dbartol commented May 23, 2024

@aeisenberg

With the category: breaking metadata, would this make the next release step bump all versions to 2.0.0?

No (although that's exactly what I was worried about). codeql pack release computes the new version number by bumping the version number of the previous release, and then uses either that or the current version number, whichever is higher. So, for a pack that was last released as 0.9.1, we get:

previousVersion = 0.9.1
bumpedVersion = 0.10.0  // 0.9.1, bumped for a breaking change, which bumps the minor version number because the major version number is 0
currentVersion = 1.0.0  // We removed the '-dev' suffix already
newVersion = 1.0.0  // max(0.10.0, 1.0.0)

(You can see the result in the test release prep PR I linked above).

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM.

Since there's no rush, maybe keep this open for a couple of days to see if anyone on the languages team has any comments.

@dbartol dbartol merged commit 6f67f9e into main May 23, 2024
57 of 59 checks passed
@dbartol dbartol deleted the dbartol/v1 branch May 23, 2024 21:32
@dbartol
Copy link
Contributor Author

dbartol commented May 23, 2024

I went ahead and merged it. The corresponding issue has been open for a week, and publicized on Slack, so I think we've had adequate opportunity for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants