Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: Use shared library for sensitive private information heuristics #16570

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented May 23, 2024

This is a simple follow-up to #16446 , which added the private information heuristics from Swift to the shared sensitive data library. This PR deletes them from Swift, deferring to the shared library instead, so that we only have one copy to maintain.

There are two differences:

  • terms for "ssn" and "ccn" have been added; these were discussed and tested (including an ad-hoc MRVA run for Swift) in the shared PR and I'm happy that we're now adding them to Swift.
  • terms for "email" have been removed in the shared library, due to noise apparently. I've never seen that issue in Swift (and I have seen useful results from the term), so I've kept them in as an additional regexp in Swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant