C#/Java: Introduce source and sink model generation sanitisers. #16759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
modelgen/sourcesinkmodelgen
branch
from
c59d15e
to
d9765ec
Compare
michaelnebel
force-pushed
the
modelgen/sourcesinkmodelgen
branch
from
d9765ec
to
2e05e88
Compare
michaelnebel
added
the
no-change-note-required
…use for summary model generation.
…all path consists of unique call targets (to avoid unwanted virtual dispatch). This severely tightens the generation of extrapolated sources.
michaelnebel
force-pushed
the
modelgen/sourcesinkmodelgen
branch
from
2e05e88
to
aa962f9
Compare
owen-mc
approved these changes
Jun 19, 2024
hvitved
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we restrict the source and sink model generation for C# and Java: If a value passes through an irrelevant type we consider the value sanitised (we do the same for summary model generation).
Furthermore, for C# we also severely limit the source model extrapolation and require that sources only propagate upwards in the call stack based on a unique callable path (to avoid unwanted virtual dispatch).