-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Convert Beego sources to MaD #16809
Conversation
Click to show differences in coveragegoGenerated file changes for go
- `beego <https://beego.me/>`_,"``github.com/astaxie/beego*``, ``github.com/beego/beego*``",,42,
+ `beego <https://beego.me/>`_,"``github.com/astaxie/beego*``, ``github.com/beego/beego*``",63,49,
- Totals,,20,877,24
+ Totals,,83,884,24
- github.com/astaxie/beego,,,7,,,,7,
+ github.com/astaxie/beego,,6,7,,,6,7,
- github.com/astaxie/beego/context,,,1,,,,1,
+ github.com/astaxie/beego/context,,15,1,,,15,1,
+ github.com/beego/beego,,6,7,,,6,7,
+ github.com/beego/beego/context,,15,,,,15,,
- github.com/beego/beego/server/web,,,7,,,,7,
+ github.com/beego/beego/server/web,,6,7,,,6,7,
- github.com/beego/beego/server/web/context,,,1,,,,1,
+ github.com/beego/beego/server/web/context,,15,1,,,15,1, |
f8646b4
to
387bc04
Compare
Do we think this needs a change note? (cf Java: Convert implementations of Since the existing QL classes are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But should probably rebase and re-run tests to re-check provenance numbers
5f80b80
to
801edda
Compare
@egregius313 I rebased and CI passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Convert Beego sources to MaD. Also add in some missing summary models (with a different module path) that I spotted at the same time.
This should be merged after #16799.
I don't believe it needs a change note.