Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Convert Beego sources to MaD #16809

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jun 21, 2024

Convert Beego sources to MaD. Also add in some missing summary models (with a different module path) that I spotted at the same time.

This should be merged after #16799.

I don't believe it needs a change note.

@github-actions github-actions bot added the Go label Jun 21, 2024
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
-    `beego <https://beego.me/>`_,"``github.com/astaxie/beego*``, ``github.com/beego/beego*``",,42,
+    `beego <https://beego.me/>`_,"``github.com/astaxie/beego*``, ``github.com/beego/beego*``",63,49,
-    Totals,,20,877,24
+    Totals,,83,884,24
  • Changes to framework-coverage-go.csv:
- github.com/astaxie/beego,,,7,,,,7,
+ github.com/astaxie/beego,,6,7,,,6,7,
- github.com/astaxie/beego/context,,,1,,,,1,
+ github.com/astaxie/beego/context,,15,1,,,15,1,
+ github.com/beego/beego,,6,7,,,6,7,
+ github.com/beego/beego/context,,15,,,,15,,
- github.com/beego/beego/server/web,,,7,,,,7,
+ github.com/beego/beego/server/web,,6,7,,,6,7,
- github.com/beego/beego/server/web/context,,,1,,,,1,
+ github.com/beego/beego/server/web/context,,15,1,,,15,1,

@owen-mc owen-mc marked this pull request as ready for review June 22, 2024 20:18
@owen-mc owen-mc requested a review from a team as a code owner June 22, 2024 20:18
@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Jun 22, 2024
@owen-mc owen-mc requested a review from egregius313 June 27, 2024 06:09
@egregius313
Copy link
Contributor

Do we think this needs a change note? (cf Java: Convert implementations of LocalUserInput to Models-as-Data)

Since the existing QL classes are private I think it's fine to exclude one for this PR.

Copy link
Contributor

@egregius313 egregius313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But should probably rebase and re-run tests to re-check provenance numbers

@owen-mc
Copy link
Contributor Author

owen-mc commented Jul 1, 2024

@egregius313 I rebased and CI passed.

Copy link
Contributor

@egregius313 egregius313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-mc owen-mc merged commit c7ad0ad into github:main Jul 2, 2024
13 checks passed
@owen-mc owen-mc deleted the go/mad-sources-beego branch July 2, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants