Java: add diagnostic query indicating low database quality

[smowton]

No description provided.

[saritai]

@smowton Some small style things in the warning text but overall looks good from a docs perspective!

[smowton]

Here's the TSP updated with the latest text: https://github.com/smowton/test-diagnostics-from-ql/security/code-scanning/tools/CodeQL/status/configurations/api/0a0e717e7702ad6128802b437a72832333465cec67163ebe61b8292092f457c4

[aeisenberg]

This makes a lot of sense and will be really useful. I do have a question about the change in the workflows.

[aeisenberg]

Also, does this affect C# as well? Should we make the same change for that language, too?

[coadaflorin]

Also, does this affect C# as well? Should we make the same change for that language, too?

It does, but we just shipped to public beta to C# and we want to wait a little while to look at the data to see where we put the line for 🟡 / 🟢

[yo-h]

Green is meant to indicate that the quality of the database is close to a traced database. Yellow is meant to indicate that it is not. For both Java and C#, 95% seems to be a sensible threshold based on that principle. This may result in more % of databases being flagged for C#, but that makes sense, as it's consistent with the data.