C++ SimpleRangeAnalysis: remove float bounds #16862
Open
+23
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d10c
changed the title
MathiasVP
reviewed
Jun 28, 2024
| @@ -5,7 +5,7 @@ | |||
| * @kind path-problem | |||
| * @problem.severity warning | |||
| * @security-severity 8.6 | |||
| * @precision high | |||
| * @precision medium | |||
There was a problem hiding this comment.
Reducing the precision of a query from high to medium means it's no longer running as part of Code Scanning. In the past we've not done such drastic changes, so I don't think we should do that as part of this PR.
If you're concerned with the new FP on the query then we could put a barrier on all dataflow nodes with a floating point types in the configuration here.
There was a problem hiding this comment.
Ok, you can check out the latest commit.
d10c
force-pushed
the
d10c/simplera-remove-float-bounds
branch
from
f4da707
to
fd21a72
Compare
If this doesn't break any tests, then this will simplify the rewrite of all SimpleRangeAnalysis floats to BigInt.
We are mostly losing precision due to excluding float operations from range analysis.
This leads to two regressions, but this should be OK if we decide to drop float support from SimpleRangeAnalysis Keeping high query precision to keep it in code scanning.
d10c
force-pushed
the
d10c/simplera-remove-float-bounds
branch
from
d4a2c1e
to
6589fc5
Compare
MathiasVP
reviewed
Jul 5, 2024
d10c
force-pushed
the
d10c/simplera-remove-float-bounds
branch
from
2da7703
to
b123901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change should simplify the SimpleRangeAnalysis library down the line by ignoring floats, but it also reduces the precision of some queries.
Some coding standard tests are also expected to fail for the same reason. So I'll leave it to the C/C++ team's discretion whether to move forward in this direction.
Commits: