Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Adopt shared SSA library #16900

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Java: Adopt shared SSA library #16900

wants to merge 1 commit into from

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jul 3, 2024

No description provided.

@github-actions github-actions bot added the Java label Jul 3, 2024
@hvitved hvitved force-pushed the java/shared-ssa branch 3 times, most recently from 1d5e5ac to 551238a Compare July 5, 2024 13:36
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 8, 2024
View reviewed changes
java/ql/src/Violations of Best Practice/Dead Code/DeadLocals.qll
not exists(SsaImplicitInit init | init.captures(ssa)) and
not emptyDecl(ssa) and
not readImplicitly(ssa, _)
/** A dead variable update. */

Check warning

Code scanning / CodeQL

Predicate QLDoc style. Warning

The QLDoc for a predicate without a result should start with 'Holds'.
@hvitved hvitved force-pushed the java/shared-ssa branch 2 times, most recently from 4479e03 to a93188c Compare July 8, 2024 18:55
@hvitved hvitved mentioned this pull request Jul 9, 2024
Merged
@hvitved hvitved changed the title Java: Adopt shared SSA data-flow integration (WIP) Java: Adopt shared SSA library Jul 9, 2024
@hvitved hvitved force-pushed the java/shared-ssa branch 2 times, most recently from ab9d191 to 910f049 Compare July 10, 2024 07:45
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 10, 2024
View reviewed changes
shared/ssa/codeql/ssa/Ssa.qll Outdated
Comment on lines 1329 to 1332
e = DfInput::getARead(_)
or
DfInput::ssaDefAssigns(_, e) and
isPost = false

Check warning

Code scanning / CodeQL

Var only used in one side of disjunct. Warning

The
variable isPost
Loading
is only used in one side of disjunct.
java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll

Location getLocation() { result = super.getLocation() }

predicate hasCfgNode(BasicBlock bb, int i) { this = bb.(J::BasicBlock).getNode(i) }

Check warning

Code scanning / CodeQL

Redundant cast Warning

Redundant cast to
BasicBlock
Loading
.
shared/ssa/codeql/ssa/Ssa.qll Fixed Show fixed Hide fixed
@hvitved hvitved force-pushed the java/shared-ssa branch 3 times, most recently from 4db2c2b to 3d63764 Compare July 11, 2024 09:38
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 11, 2024
View reviewed changes
shared/ssa/codeql/ssa/Ssa.qll Outdated
Comment on lines 1330 to 1339
e = DfInput::getARead(_)
or
DfInput::ssaDefAssigns(_, e) and
isPost = false

Check warning

Code scanning / CodeQL

Var only used in one side of disjunct. Warning

The
variable isPost
Loading
is only used in one side of disjunct.
@hvitved hvitved force-pushed the java/shared-ssa branch 2 times, most recently from 308fce2 to de69820 Compare July 11, 2024 19:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 11, 2024
View reviewed changes
shared/ssa/codeql/ssa/Ssa.qll Outdated
Comment on lines 1356 to 1340
e = DfInput::getARead(_)
or
exists(DefinitionExt def |
DfInput::ssaDefAssigns(def, e) and
hasCertainRead(def) and
isPost = false
)

Check warning

Code scanning / CodeQL

Var only used in one side of disjunct. Warning

The
variable isPost
Loading
is only used in one side of disjunct.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 12, 2024
View reviewed changes
shared/ssa/codeql/ssa/Ssa.qll Outdated

private newtype TNode =
TParamNode(DfInput::Parameter p) {
exists(WriteDefinition def | DfInput::ssaDefInitializesParam(def, p))

Check warning

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hvitved