Don't chain to ./codeql in .codeqlmanifest.json #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This entry in `.codeqlmanifest.json` was intended to allow unpacking the CodeQL CLI as a subdirectory of `ql`, and things would Just Work. However, it is not necessary anymore because recent releases of the CLI will search their own directory as a fallback _independently_ of the parent directory. On the contrary, removing this link will make internal testing easier because you then run a test build of the CLI with `--search-path` pointing to the `ql` checkout without inadvertently making extractors in a _different_ build that is unpacked there visible.
nickrolfe
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This entry in
.codeqlmanifest.jsonwas intended to allow unpacking the CodeQL CLI as a subdirectory ofql, and things would Just Work.However, it is not necessary anymore because recent releases of the CLI will search their own directory as a fallback independently of the parent directory.
On the contrary, removing this link will make internal testing easier because you then run a test build of the CLI with
--search-pathpointing to theqlcheckout without inadvertently making extractors in a different build that is unpacked there visible.