Java: Add modelling for Guava #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
reviewed
Oct 2, 2020
|
I think having one QLL files for each Java class is a bit overkill. It might be better to group things per package or per theme somehow. |
Good point, all of these could go under something like |
|
The additional Guava modelling is worth a change note. |
joefarebrother
force-pushed
the
guava-strings
branch
from
1df6ba1
to
8cd00cf
Compare
Marcono1234
reviewed
Oct 17, 2020
| @@ -0,0 +1,2 @@ | |||
| lgtm,codescanning | |||
| * Some methods of the [Guava](https://guava.dev/) framework have been added as flow steps (specifically those of the [Splitter](https://guava.dev/releases/29.0-jre/api/docs/com/google/common/base/Splitter.html), [Joiner](https://guava.dev/releases/29.0-jre/api/docs/com/google/common/base/Joiner.html), and [Strings](https://guava.dev/releases/29.0-jre/api/docs/com/google/common/base/Strings.html) classes), which may lead to more results from the security queries. | |||
There was a problem hiding this comment.
Guava 30.0 has just been released. Would it make sense to adjust the links and the stubs?
Based on the changelog it looks like none of the classes covered by this pull request changed.
Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>
aschackmull
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds taint steps for
com.google.common.base.Strings,com.google.common.base.Splitter, andcom.google.common.base.Joiner.Also adds
Strings.isNullOrEmptyas a null guard.Part of https://github.com/github/codeql-java-team/issues/39.
Fixes #4355.