Use chromium for karma tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this one currently has a failing test when running in Codespaces with Chromium. Need to circle back to investigate ... |
theinterned
force-pushed
the
theinterned/install-chromium
branch
from
c459edf
to
0d49556
Compare
theinterned
commented
Feb 17, 2022
| @@ -219,7 +219,7 @@ describe('combobox-nav', function() { | |||
|
|
|||
| assert.equal(options[1].getAttribute('aria-selected'), 'true') | |||
| assert.equal(input.getAttribute('aria-activedescendant'), 'hubot') | |||
| assert.equal(list.scrollTop, 36) | |||
| assert.equal(list.scrollTop, options[1].offsetTop) | |||
There was a problem hiding this comment.
this test was failing ... it seems that the height of the list items can vary by platform. This removes the magic number.
keithamus
approved these changes
Feb 21, 2022
theinterned
commented
Feb 22, 2022
| @@ -3,7 +3,7 @@ name: Node CI | |||
| on: | |||
| pull_request: | |||
| branches: | |||
| - master | |||
There was a problem hiding this comment.
CI was not running! This fixes that 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What am I trying to accomplish
Provide a Chromium binary for front-end projects to run karma tests with when running in Codespaces or other environments where chrome browser is not necessarily installed.
Part of https://github.com/github/web-systems/issues/162 (see that issue for more info)
What approach did I take?
I installed and configured the
chromiumnpm package for use with karma tests.