Bump dockerode and @types/dockerode #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/dockerode-and-types/dockerode-3.3.4
branch
5 times, most recently
from
fb381ea
to
0c6b81e
Compare
bdragon
force-pushed
the
dependabot/npm_and_yarn/dockerode-and-types/dockerode-3.3.4
branch
2 times, most recently
from
93265ea
to
2860cf3
Compare
|
I've duplicated this branch to https://github.com/github/dependabot-action/tree/dockerode-backup. Going to have dependabot recreate this and re-apply the fixes. |
|
@dependabot recreate |
Bumps [dockerode](https://github.com/apocas/dockerode) and [@types/dockerode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/dockerode). These dependencies needed to be updated together. Updates `dockerode` from 3.3.1 to 3.3.4 - [Release notes](https://github.com/apocas/dockerode/releases) - [Commits](apocas/dockerode@v3.3.1...v3.3.4) Updates `@types/dockerode` from 3.2.6 to 3.3.11 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/dockerode) --- updated-dependencies: - dependency-name: dockerode dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: "@types/dockerode" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/dockerode-and-types/dockerode-3.3.4
branch
from
2860cf3
to
161f7ff
Compare
Co-authored-by: Bryan Dragon <25506+bdragon@users.noreply.github.com>
Co-authored-by: Bryan Dragon <25506+bdragon@users.noreply.github.com>
Initially this branch was failing lint checks in CI due to a mismatch between the type of argument we pass to dockerode's `Docker.listImages()` and the TypeScript type definition for that method. Reading the type definition, the method expects `filters` to be a string where we were passing an object. (Docker _does_ want a string, but a JSON-encoded one.) It turns out that dockerode and docker-modem automatically convert options like this one to JSON-encoded strings as of apocas/docker-modem@fa5a2b7. However, passing anything other than a string still fails type checking. Co-authored-by: Bryan Dragon <25506+bdragon@users.noreply.github.com>
bdragon
approved these changes
Feb 2, 2023
landongrindheim
deleted the
dependabot/npm_and_yarn/dockerode-and-types/dockerode-3.3.4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps dockerode and @types/dockerode. These dependencies needed to be updated together.
Updates
dockerodefrom 3.3.1 to 3.3.4Commits
ad170f5version bumpe5ddd6bMerge pull request #676 from jossemarGT/improve-dockerignore-support2312b40Groom the Vagrantfileb65a4dcAdd .dockerignore support for blobs and dirsc4b7740readmeaccbe91Merge pull request #606 from lucamaraschi/mastere1df732v3.3.37531af3actions typoe5be1a1github actions04700f2experimental features testsUpdates
@types/dockerodefrom 3.2.6 to 3.3.11Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)