Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC - Adding permissions settings #14998

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Conversation

martin389
Copy link
Contributor

@martin389 martin389 commented Feb 3, 2022

Why:

Closes #14626

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@martin389 martin389 self-assigned this Feb 3, 2022
@github-actions github-actions bot added this to Triage in Docs open source board Feb 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect.md Modified Original
content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services.md Modified Original
content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-azure.md Modified Original
content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers.md Modified Original
content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform.md Modified Original
content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-hashicorp-vault.md Modified Original

@github-actions github-actions bot temporarily deployed to docs-14998--14626-update-token February 3, 2022 07:38 Inactive
@ramyaparimi ramyaparimi added waiting for review Issue/PR is waiting for a writer's review content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team labels Feb 3, 2022
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍

@lucascosti lucascosti enabled auto-merge (squash) February 4, 2022 00:34
@github-actions github-actions bot temporarily deployed to docs-14998--14626-update-token February 4, 2022 00:40 Inactive
@lucascosti lucascosti merged commit 560193f into main Feb 4, 2022
Docs open source board automation moved this from Triage to Done Feb 4, 2022
@lucascosti lucascosti deleted the 14626-update-token-details branch February 4, 2022 00:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Document id-token permission
3 participants