Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reusables.actions.action-setup-python@v4, not @v3 #18767

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 22, 2022

https://github.com/actions/setup-python/releases

reusables.actions.action-setup-python should be upgraded to setup-python@4, not @3.

Why:

See improvements and bug fixes at https://github.com/actions/setup-python/releases

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

https://github.com/actions/setup-python/releases

`reusables.actions.action-setup-python` should be upgraded to [`setup-python@4`](https://github.com/actions/setup-python/releases), not `@3`.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 22, 2022
@janiceilene
Copy link
Contributor

@cclauss Thanks so much for opening a PR! I'll get this triaged for review ✨

In the meantime, can you add some information to the Why section of the OP ☝️ to explain why this change should be made in the docs?

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 28, 2022
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jun 28, 2022
@docubot docubot added this to Triage in Docs open source board Jun 28, 2022
@janiceilene janiceilene merged commit 8a2c410 into github:main Jun 29, 2022
Docs open source board automation moved this from Triage to Done Jun 29, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants