Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fully formed ref of the merge branch in cache cleanup action #23612

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Add fully formed ref of the merge branch in cache cleanup action #23612

merged 2 commits into from
Jan 31, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jan 31, 2023

Why:

Closes #22727

What's being changed (if available, include any code snippets, screenshots, or gifs):

Corrects the merge branch name in cache cleanup action

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Jan 31, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 31, 2023
@trivikr trivikr mentioned this pull request Jan 31, 2023
Closed
1 task
@trivikr
Copy link
Contributor Author

trivikr commented Jan 31, 2023

cc @SiaraMist who provided feedback on the issue at #22727 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023 •
edited

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/caching-dependencies-to-speed-up-workflows.md fpt
ghec
ghes@ 3.7 3.6 3.5
fpt
ghec
ghes@ 3.7 3.6 3.5

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

SiaraMist
SiaraMist approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trivikr! I'll go ahead and get this merged. 🚀

@SiaraMist SiaraMist added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Jan 31, 2023
@docubot docubot added this to Triage in Docs open source board Jan 31, 2023
@SiaraMist SiaraMist enabled auto-merge (squash) January 31, 2023 20:24
@SiaraMist SiaraMist merged commit 93d6cc3 into github:main Jan 31, 2023
Docs open source board automation moved this from Triage to Done Jan 31, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@trivikr trivikr deleted the patch-1 branch January 31, 2023 20:34
@lucascosti lucascosti mentioned this pull request Feb 2, 2023
Closed
1 task
@andreasabel andreasabel mentioned this pull request Feb 8, 2023
Merged
@Mogyuchi Mogyuchi mentioned this pull request Mar 7, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiaraMist SiaraMist SiaraMist approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
Docs open source board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The github.ref does not contain fully-formed ref of the branch
2 participants
@trivikr @SiaraMist