Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates environment files documentation #33197

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

Haimantika
Copy link
Contributor

Why: Adds more information about environment files

Closes: #31568

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adds example about how .env file can be used.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 28, 2024
Copy link
Contributor

github-actions bot commented May 28, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@Haimantika
Copy link
Contributor Author

From what I understand, the errors are occurring because of the mention of GitHub docs link. Not sure how to solve that.

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 28, 2024
@nguyenalex836
Copy link
Contributor

@Haimantika Thanks so much for opening a PR! I'll get this triaged for review ✨ We will take a look at that failed deployment check on our end 💛

@Haimantika
Copy link
Contributor Author

@Haimantika Thanks so much for opening a PR! I'll get this triaged for review ✨ We will take a look at that failed deployment check on our end 💛

Let me know if you have any feedback on the PR :)

@Haimantika
Copy link
Contributor Author

Hi @nguyenalex836 is there any changes needed from my end?

@nguyenalex836
Copy link
Contributor

@Haimantika Hello! No changes needed from you currently ✨ Once our team is able to review your PR, you will be the first to know 💛 thank you!

@Haimantika
Copy link
Contributor Author

@Haimantika Hello! No changes needed from you currently ✨ Once our team is able to review your PR, you will be the first to know 💛 thank you!

Thanks for the update!

SiaraMist
SiaraMist previously approved these changes Jun 13, 2024
Copy link
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Haimantika, thank you so much for making these updates! They are awesome and I think will be really helpful for people to understand environment files. ✨

I just made one change to fix a linter error, and now I'm going to get this merged. Thank you again! 💛

@Haimantika
Copy link
Contributor Author

@Haimantika, thank you so much for making these updates! They are awesome and I think will be really helpful for people to understand environment files. ✨

I just made one change to fix a linter error, and now I'm going to get this merged. Thank you again! 💛

Thank you so much Siara!

@SiaraMist SiaraMist added this pull request to the merge queue Jun 13, 2024
Merged via the queue into github:main with commit c4f0758 Jun 13, 2024
45 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generic information on how the environment files work for GitHub Action Workflow Commands
3 participants