Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 33136 move period inside quotation #33284

Merged

Conversation

SeanAverS
Copy link
Contributor

Why:

Move period inside quotation in "upstream branch" term to align with style guide

Closes: #33136

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Move the period to the inside of the ending quotation

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 31, 2024
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels May 31, 2024
@nguyenalex836
Copy link
Contributor

@SeanAverS Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue May 31, 2024
Merged via the queue into github:main with commit 1481040 May 31, 2024
58 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move period inside ending quotation marks in github-glossary#upstream-branch
2 participants