Update ldap.rb to allow unencrypted LDAP Access #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was failing because ``` vendor/gems/ruby/3.1.0/gems/net-ldap-0.17.1/lib/net/ldap/connection.rb:72:in `open_connection': unsupported encryption method (Net::LDAP::Error) ``` The "nil" encryption method doesn't exist, to not use encryption, we can just omit the `encryption` parameter
cwage
approved these changes
Apr 3, 2023
cwage
approved these changes
Apr 3, 2023
DanHoerst
approved these changes
Apr 3, 2023
|
@Shaeli do you have a Rubygems account? I'll need to give you push access before you can run |
|
@DanHoerst I don't have one but I can create one |
GrantBirki
approved these changes
Aug 28, 2023
|
I have some changes coming up and would like to get this merged for you so I don't leave this PR in a state of wild merge conflicts. @DanHoerst I have a RubyGems account and can merge this, then run My account is: https://rubygems.org/profiles/GrantBirki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is failing when connecting to an LDAP with no encryption enabled
The "nil"
encryptionmethod doesn't exist, to not use encryption, we can just omit theencryptionkey in the options hashSee https://www.rubydoc.info/gems/net-ldap/Net%2FLDAP:initialize for more info