Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info into the meta property of rules #122

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Mar 31, 2021

It's good to have this info filled out. I was also hoping we could add https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin to lint these rules and their tests; this change is in preparation for that.

References

https://eslint.org/docs/developer-guide/working-with-rules#rule-basics

@koddsson koddsson requested a review from a team as a code owner March 31, 2021 14:33
@koddsson koddsson requested review from T-Hugs and srt32 March 31, 2021 14:33
lib/rules/array-foreach.js Outdated Show resolved Hide resolved
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great cleanup!

@koddsson koddsson merged commit 737cee6 into main Apr 1, 2021
@koddsson koddsson deleted the set-correct-meta-info-on-rules branch April 1, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants