-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter repositories in scope by their visibility #60
Conversation
Looks like there are some conflicts on this one. Would you be able to take a look at resolving them @gbrindisi ? |
@zkoppert done, tests are ok and I run it locally and works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feature! Thanks for contributing!
@zkoppert sorry for the confusion, I tested without noticing that I had the env variable set in my environment. I reworked the code a bit to make it more testable. |
Shouldn't jscpd ignore all test files? evergreen/.github/linters/.jscpd.json Line 4 in 874f794
It seems that the
This config might work?
|
@zkoppert ouch this closed automatically, take a look please 🙏 |
Pull Request
Filter repositories in scope by their visibility
Proposed Changes
This PR add a configuration option to control the scope of evergreen based on the target repositories visibility.
By default all repositories are in scope, but if users desire to limit evergreen to only public repositories they now can do so by setting
FILTER_VISIBILITY
topublic
.If they want to target private and internal repositories they can set it to
private,internal
and so on.Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducingReviewer
bug
,documentation
,enhancement
,infrastructure
, orbreaking