Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ignore directive of jscpd is not working as expected #66

Merged
merged 1 commit into from
Mar 1, 2024
Merged

The ignore directive of jscpd is not working as expected #66

merged 1 commit into from
Mar 1, 2024

Conversation

gbrindisi
Copy link
Contributor

@gbrindisi gbrindisi commented Mar 1, 2024 •
edited by zkoppert
Loading

Pull Request

The ignore directive of jscpd is not working as expected

Proposed Changes

Fixes #60

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@gbrindisi gbrindisi requested a review from zkoppert as a code owner March 1, 2024 08:56
zkoppert
zkoppert approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@zkoppert zkoppert added the bug Something isn't working label Mar 1, 2024
@zkoppert zkoppert merged commit 42556ba into github:main Mar 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbrindisi @zkoppert