Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global usings and no braces namespaces #148

Closed
wants to merge 1 commit into from
Closed

global usings and no braces namespaces #148

wants to merge 1 commit into from

Conversation

dylan-smith
Copy link
Collaborator

@dylan-smith dylan-smith commented Nov 20, 2021 •
edited
Loading

Part of #143

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked

@github-actions
Copy link

Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
27 tests ±0  27 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 22ce51b. ± Comparison against base commit d7badbe.

@dylan-smith dylan-smith enabled auto-merge (squash) November 20, 2021 17:35
@dylan-smith
Copy link
Collaborator Author

Looks like CodeQL and C# 10 features don't play nice together, reaching out to CodeQL team in slack.

@dylan-smith
Copy link
Collaborator Author

Looks like CodeQL doesn't support C# 10 features yet. There is an open issue for it here: github/codeql#7086

@dylan-smith
Copy link
Collaborator Author

Will close for now and revisit if/when codeql introduces support for C# 10

auto-merge was automatically disabled November 30, 2021 14:18

Pull request was closed

@dylan-smith dylan-smith deleted the dylan-smith/dotnet-6-improvements branch July 14, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dylan-smith