-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate --ssh
flag
#269
Deprecate --ssh
flag
#269
Conversation
Unit Test Results 1 files ± 0 1 suites ±0 14s ⏱️ ±0s Results for commit 3974d39. ± Comparison against base commit baca36b. This pull request removes 13 tests.
♻️ This comment has been updated with latest results. |
should add a bullet to release notes for this |
Yup :) while I was adding it I noticed that it'd be a good idea to also test for |
Closes #265
Because of the latest BE changes and the fact that the problems we had with
https
are now resolved, we can deprecate the--ssh
flag and usehttps
permanently. For backward compatibility, we are not going to remove it completely just yet so passing it will do noting (keep usinghttps
) and log a warning to notify the user.ado2gh generate-script output with --ssh