Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --ssh flag #269

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Deprecate --ssh flag #269

merged 6 commits into from
Mar 16, 2022

Conversation

ArinGhazarian
Copy link
Collaborator

@ArinGhazarian ArinGhazarian commented Mar 16, 2022

Closes #265

Because of the latest BE changes and the fact that the problems we had with https are now resolved, we can deprecate the --ssh flag and use https permanently. For backward compatibility, we are not going to remove it completely just yet so passing it will do noting (keep using https) and log a warning to notify the user.

ado2gh generate-script output with --ssh

./ado2gh generate-script --ado-org aringhazarian --github-org ArinTestOrg --repos-only --ssh 
[7:14 PM] [INFO] Generating Script...
[7:14 PM] [INFO] GITHUB ORG: ArinTestOrg
[7:14 PM] [INFO] ADO ORG: aringhazarian
[7:14 PM] [INFO] OUTPUT: ./migrate.ps1
[7:14 PM] [WARNING] SSH mode is no longer supported. --ssh flag will be ignored.
[7:14 PM] [INFO] ADO Org provided, only processing repos for aringhazarian
[7:14 PM] [INFO] ADO ORG: aringhazarian
[7:14 PM] [INFO]   Team Project: BarProject
[7:14 PM] [INFO]     Repo: BarProject
[7:14 PM] [INFO]     Repo: DragonRepo
[7:14 PM] [INFO]   Team Project: FooProject
[7:14 PM] [INFO]     Repo: JohnRepo
[7:14 PM] [INFO]     Repo: FooProject
[7:14 PM] [INFO]   Team Project: MigrationTestProject

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked

@github-actions
Copy link

github-actions bot commented Mar 16, 2022

Unit Test Results

    1 files  ±  0      1 suites  ±0   14s ⏱️ ±0s
205 tests  - 13  205 ✔️  - 13  0 💤 ±0  0 ±0 

Results for commit 3974d39. ± Comparison against base commit baca36b.

This pull request removes 13 tests.
OctoshiftCLI.Tests.AdoToGithub.Commands.GenerateScriptCommandTests ‑ OctoshiftCLI.Tests.AdoToGithub.Commands.GenerateScriptCommandTests.GenerateParallelScript_Single_Repo_Repos_Only_With_Ssh
OctoshiftCLI.Tests.AdoToGithub.Commands.GenerateScriptCommandTests ‑ OctoshiftCLI.Tests.AdoToGithub.Commands.GenerateScriptCommandTests.Single_Repo_Repos_Only_With_Ssh
OctoshiftCLI.Tests.AdoToGithub.Commands.MigrateRepoCommandTests ‑ OctoshiftCLI.Tests.AdoToGithub.Commands.MigrateRepoCommandTests.Retries_When_Hosts_Error_And_Wait_Is_On
OctoshiftCLI.Tests.AdoToGithub.Commands.MigrateRepoCommandTests ‑ OctoshiftCLI.Tests.AdoToGithub.Commands.MigrateRepoCommandTests.With_Ssh
OctoshiftCLI.Tests.GithubApiTests ‑ OctoshiftCLI.Tests.GithubApiTests.CreateAdoMigrationSource_Using_Ssh
OctoshiftCLI.Tests.GithubApiTests ‑ OctoshiftCLI.Tests.GithubApiTests.CreateGhecMigrationSource_Using_Ssh
OctoshiftCLI.Tests.GithubEnterpriseImporter.Commands.GenerateScriptCommandTests ‑ OctoshiftCLI.Tests.GithubEnterpriseImporter.Commands.GenerateScriptCommandTests.Ado_With_Ssh
OctoshiftCLI.Tests.GithubEnterpriseImporter.Commands.GenerateScriptCommandTests ‑ OctoshiftCLI.Tests.GithubEnterpriseImporter.Commands.GenerateScriptCommandTests.GenerateParallelAdoScript_Single_Repo_With_Ssh
OctoshiftCLI.Tests.GithubEnterpriseImporter.Commands.GenerateScriptCommandTests ‑ OctoshiftCLI.Tests.GithubEnterpriseImporter.Commands.GenerateScriptCommandTests.GenerateParallelGithubScript_Single_Repo_With_Ssh
OctoshiftCLI.Tests.GithubEnterpriseImporter.Commands.GenerateScriptCommandTests ‑ OctoshiftCLI.Tests.GithubEnterpriseImporter.Commands.GenerateScriptCommandTests.Github_With_Ssh
…

♻️ This comment has been updated with latest results.

@dylan-smith
Copy link
Collaborator

should add a bullet to release notes for this

@ArinGhazarian
Copy link
Collaborator Author

should add a bullet to release notes for this

Yup :) while I was adding it I noticed that it'd be a good idea to also test for option.IsHidden in the command tests. Adding the ReleaseNotes now 😃

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Octoshift 86% 61% 213
gei 66% 60% 227
ado2gh 90% 77% 273
Summary 82% (2438 / 2985) 68% (373 / 552) 713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the ssh support
2 participants