Add basic test for hooks #1179
Merged
Add basic test for hooks #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvaillancourt
force-pushed
the
logic-hooks-tests
branch
2 times, most recently
from
66464e2
to
e53bbce
Compare
timvaillancourt
force-pushed
the
logic-hooks-tests
branch
from
1761df2
to
50bf651
Compare
dm-2
approved these changes
Oct 21, 2022
RainbowDashy
pushed a commit
to bytebase/gh-ost
that referenced
this pull request
Dec 13, 2022
d-bytebase
pushed a commit
to bytebase/gh-ost
that referenced
this pull request
Dec 13, 2022
* Add script and docs for linter (github#1151) * Enable more `golang-ci` linters (github#1149) * Only build RPM and deb packages for amd64 * Convert character to bytes and insert into table using latin1 * delete junk files * restore connection charset to utf8mb4 * Allow zero in dates (github#1161) * Merge pull request #31 from openark/zero-date Support zero date and zero in date, via dedicated command line flag * Merge pull request #32 from openark/existing-date-with-zero Support tables with existing zero dates * Remove un-needed ignore_versions file * Fix new lint errors from golang-ci update Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Add missing doc from PR github#1131 (github#1162) * Set a transaction isolation level for MySQL connections (github#1156) * Set transaction isolation in connections * Revert load_map.go change * Var rename * Restore comment * Some fix to unit tests. * convert to bytes if character string without charsetConversion. * chore: remove duplicate word in comments (github#1175) Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Abirdcfly <fp544037857@gmail.com> * Improve applier `.ReadMigrationRangeValues()` func accuracy (github#1164) * Use a transaction in applier `ReadMigrationRangeValues` func * Private func names * Add basic tests for applier (github#1165) * Add basic tests for applier * Add header * Add basic test for inspector (github#1166) * Add basic test for inspector * Add header * Fix return * Add basic tests to migrator (github#1168) * add-rocksdb-as-transactional-engine * Add basic test for hooks (github#1179) * Enable more `golangci-lint` linters (github#1181) * Print status to migration context logger * fix CI tests to ubuntu-20.04 because ubuntu-22.04 (current -latest) doesn't support MySQL 5.7 * temp commit to investigate datetime-with-zero test failure * more testing * add extra debugging output * debugging * add error detection for test setup, sort tests to make it easier to track progress * fix broken test by removing invalid insert statement * Fix: Change table name table name is 'tbl' not 'tble' * Attempt instant DDL if supported * minor cleanup * Add tests, incorporate feedback * Improve docs * Address PR feedback * Make it clear in docs it is disabled by default but safe. * Update go/logic/migrator.go Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com> * remove useless func per review * support rocksdb as transactional engine * Modify tests to support rocksdb tests * SetConnectionConfig * add support for rocksdb * add support for rocksdb * add percona to versions in workflows * add description and optimize tests * Apply suggestions from code review Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update go/logic/applier.go Signed-off-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com> Co-authored-by: wangzihuacool <wangzihuacool@163.com> Co-authored-by: wangzihuacool <47876169+wangzihuacool@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Nicholas Calugar <nicholas.calugar@gusto.com> Co-authored-by: Hasan Mshawrab <63023909+hasanMshawrab@users.noreply.github.com> Co-authored-by: Morgan Tocker <mtocker@squareup.com> Co-authored-by: Morgan Tocker <tocker@gmail.com> Co-authored-by: lukelewang <lukelewang@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a simple test for
go/logic/hooks.goIn the process I found that the
initHooks()func ofHooksExecutorhas a staticreturn niland no other logic, making it fairly useless.migrator.initiateHooksExecutor()was modified to remove the call toinitHooks(), making it unnecessary as well.HooksExecutoris now instantiated inNewMigratorto simplify the codeLastly,
executeHooks()andexecuteHook()(fromHooksExecutor) were updated to use anout io.Writerfor output to facilitate testingscript/cibuildreturns with no formatting errors, build errors or unit test errors.