Add support for before_delivery in get requests

github · Apr 8, 2018 · 5bf6a9d · 5bf6a9d
1 parent 45d6348
commit 5bf6a9d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/service.rb b/lib/service.rb
@@ -568,6 +568,11 @@ def shorten_url(url)
   def http_get(url = nil, params = {}, headers = {})
     raise_config_error("Invalid scheme") unless permitted_transport?(url)
     url = url.strip if url
+
+    if pre_delivery_callbacks.any?
+      pre_delivery_callbacks.each { |c| c.call(url, nil, headers, params) }
+    end
+
     http.get do |req|
       req.url(url)                if url
       req.params.update(params)   if params

diff --git a/test/service_test.rb b/test/service_test.rb
@@ -202,13 +202,13 @@ def test_multiple_before_delivery_callbacks
       headers['EDITED-IN-BEFORE-DELIVERY-2'] = true
     end
 
-    @stubs.post '/' do |env|
+    @stubs.get '/' do |env|
       assert_equal true, env[:request_headers]['Edited-In-Before-Delivery-1']
       assert_equal true, env[:request_headers]['Edited-In-Before-Delivery-2']
       [200, {'X-Test' => 'success'}, 'OK']
     end
 
-    @service.http_post('/', payload)
+    @service.http_get('/')
 
     @service.http_calls.each do |env|
       assert_equal 200, env[:response][:status]