FishEye service mods #477
FishEye service mods #477
Conversation
MacSwinarski
commented
Dec 20, 2012
MacSwinarski
commented
- new property names
- handling custom repository name correctly
- handling FishEye URL without protocol, ending slash
- docs
- Fix FishEye capitalization - doc field names + tweaks - make sure service param name matches expected form data
Modified input data names, docs, handling url without protocol, ending slash.
| string :url_base, :token, :repository_name | ||
| white_list :url_base, :repository_name | ||
| string :FishEye_Base_URL, :REST_API_Token, :FishEye_Repository_Name | ||
| white_list :FishEye_Base_URL, :FishEye_Repository_Name |
There was a problem hiding this comment.
Is there a reason you changed these? It'll break all old fisheye hooks.
There was a problem hiding this comment.
I've changed them to get more descriptive field names in the configuration form. matching the ones in FishEye.
Being able to trigger a scan remotely is a new feature, and not available in a released version yet, so breaking existing hooks shouldn't affect anybody.
|
@technoweenie If there aren't any issues, would it be possible to merge this? We'd like to test the integration before the release next week. Thanks! |
|
Hooks are on hold for various reasons until after next week. Also, since the keys are changing, we have to update the existing uses of the Hook to use the new filenames. They'll all break if they continue to send |
|
@technoweenie |
|
Yes. Changing keys either breaks every hook, or forces me to update them |
|
hi @technoweenie, any idea when this could me merged; |
|
Hey, don't worry about merge conflicts. I'll take care of them, since they're due to my refactoring. We're still in the middle of a big hook backend transition. Once we're on the new backend, I'll make the change. Changing the property names requires some manual work in the DB so everyones existing hooks don't break. That's why this isn't merged yet. |
|
Hey @technoweenie, sorry to bother You but maybe you have some news;) thx |
|
Hi @technoweenie, any news? let me know how can we make this pull request merged. thx |
|
I have to find a time when I can manually migrate existing hooks over to use the new properties. You can revert the property name changes and make my job a lot easier :) |
…g slashes, add http if no protocol
