Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local configuration files to Vim.gitignore #3698

Closed
wants to merge 1 commit into from

Conversation

Farzat07
Copy link

@Farzat07 Farzat07 commented Apr 8, 2021

When using coc.nvim (https://github.com/neoclide/coc.nvim), sometimes a
local configuration file is created at .vim/coc-settings.json, so it was
ignored.

I am not sure whether this directory is used by coc only or other
packages as well, so for now I think it is better to just ignore the
whole .vim/ directory.

A link to the documentation of coc's local configuration file:
https://github.com/neoclide/coc.nvim/blob/ba262ef03029c3fd6a5062bebce7d8553e3b1a1f/doc/coc.txt#L2230

When using coc.nvim (https://github.com/neoclide/coc.nvim), sometimes a
local configuration file is created at .vim/coc-settings.json, so it was
ignored.

I am not sure whether this directory is used by coc only or other
packages as well, so for now I think it is better to just ignore the
whole .vim/ directory.
@martinwoodward
Copy link
Collaborator

Are .vim folders commonly created inside directories too? I could only find reference to them being used in your profile directory.

@Farzat07
Copy link
Author

I don't really get your question.

@martinwoodward
Copy link
Collaborator

Trying to figure out why the entire .vim folder is being excluded. Does this file exist outside of the root of a users profile folder or is it sometime stored in source folders?

@Farzat07
Copy link
Author

Farzat07 commented Jun 5, 2021

Actually thinking about it, ignoring the .vim/ directory can be very damaging for someone who uses git to keep track of his home directory.

The .vim/coc-settings.json is a specific case which does not necessarily apply to the normal user.

I'm thinking of closing the pull request, is it ok?

@bl-ue
Copy link
Contributor

bl-ue commented Jun 5, 2021

is it ok?

Yes, it's perfectly fine! It's your pull request and you can do what you want with it ;)

@Farzat07 Farzat07 closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants