added excludes for vendored directories (since GO 1.5) #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable. cc @technoweenie @rubyist for a 👍 |
|
ehm, are we gonna merge this sometime or not?!? |
shiftkey
added a commit
that referenced
this pull request
Nov 2, 2015
added excludes for vendored directories (since GO 1.5)
u9E9F
pushed a commit
to u9E9F/gitignore
that referenced
this pull request
Jul 8, 2017
added excludes for vendored directories (since GO 1.5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard github .gitignore file for GO does not exclude vendored directories. Since Go 1.5, the Go compiler with look for dependencies under the
/vendor/**path first and default back to the$GOPATH/**. Most vendoring tools for go do not expect you to have the directories under/vendorchecked in but willgo getthem into the vendor directory. That's why I recommend excluding the/vendor/**directories. The/vendor/manifestfile is needed by many dependency management tools in Go to keep a record of the vendored dependencies and rebuild them if necessary - so it should not be excluded.