Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual studio new database engine #1783

Merged
merged 2 commits into from
Mar 31, 2016

Conversation

vladon
Copy link
Contributor

@vladon vladon commented Dec 4, 2015

New database engine (VS 2015) files

Added extensions of new database engine for C++ (sqlite-based) from
Visual Studio 2015
(Tools - Options - Text Editor - C/C++ - Experimental - Enable New
Database Engine)
@@ -80,6 +80,8 @@ ipch/
*.opensdf
*.sdf
*.cachefile
*.VC.db
*.VC.VC.opendb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've defined *.opendb earlier in the file - should that be more specific? Or is the general rule good enough?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1778 for that discussion cc @anurse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shiftkey If we can specify a special case, then we must do it instead of common case. The extension is always .VC.VC.opendb for the case of new database engine.

The file with this extension is created only when converting old project with .sdf databases to new engine. When the project started already as new, only .VC.db is created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK to me to shift to *.VC.db and *.VC.opendb, I do indeed see that the file always has the VC suffix.

I'd like to see if we can find anyone from the VC++ team to help. I can try to put out feelers, but I'm not sure I have the contacts :). Worst case, I'll just email Satya :trollface:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I've reached out to the right people, but I kinda just sent an email to somewhere random and am hoping it works ;).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in getting back to this:

And temporary file with *.VC.VC.opendb extension (yes, two subsequent VC) is used for new DB engine when solution is opened.

This should be covered by *.opendb on line 79, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shiftkey If we can be more specific, why not to? It is always *.VC.VC.opendb for temporary opendb created by Visual Studio. What if user will create its own *.opendb which must be in his repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladon @shiftkey's point is that we already have *.opendb in this file. So the addition of *.VC.VC.opendb does nothing. Either we remove *.VC.VC.opendb or we remove *.opendb.

@anurse was the one who added .opendb in a393ef8 so I'm not sure what the best call here is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haacked My point is that VS 2015 only uses <ProjectName>.VC.opendb and <ProjectName>.VC.VC.opendb (latter only temporarily while the project is open in IDE) for its new databases. Adding *.opendb we simply ignoring all files with that extension, it can be user files too. I think it will be best to add *.VC.VC.opendb plus *.VC.opendb and remove *.opendb line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add *.VC.opendb we won't need to add *.VC.VC.opendb. @anurse any objection to removing *.opendb?

hzor3000 added a commit to hzor3000/gitignore that referenced this pull request Jan 23, 2016
Add *.VC.opendb to the .gitignore for the UnrealEngine for Visual Studio 2015 Update 1 users. This reflects the changes in the VisualStudio.gitignore made in github#1778 and github#1783 but is more specifically targeted at solving the issue http://stackoverflow.com/questions/34319008/git-issue-with-visual-studio-2015-update-1 .
@vladon
Copy link
Contributor Author

vladon commented Mar 31, 2016

Guys, please, add this or any other PR with *.VC.db line. There is VS 2015 Update 2 released yesterday with this database format by default.

@shiftkey
Copy link
Member

@vladon apologies for the delay, and thanks for the reminder!

@shiftkey shiftkey merged commit 4caa9bf into github:master Mar 31, 2016
@vladon vladon deleted the Visual-Studio-new-database-engine branch March 31, 2016 16:26
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
Add *.VC.opendb to the .gitignore for the UnrealEngine for Visual Studio 2015 Update 1 users. This reflects the changes in the VisualStudio.gitignore made in github#1778 and github#1783 but is more specifically targeted at solving the issue http://stackoverflow.com/questions/34319008/git-issue-with-visual-studio-2015-update-1 .
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
…-engine

Visual studio new database engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants