Including recommended Symfony gitignore rules #2412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including additional rules recommended by Symfony and basic IDE rule
|
I'd be happy to have feedback if this is rejected |
shiftkey
reviewed
Sep 9, 2017
| @@ -39,3 +42,5 @@ | |||
|
|
|||
| # Backup entities generated with doctrine:generate:entities command | |||
| **/Entity/*~ | |||
| /.idea/ | |||
There was a problem hiding this comment.
This is a JetBrains rule and more nuanced than ignoring this whole folder - see Global\JetBrains.gitignore
| @@ -39,3 +42,5 @@ | |||
|
|
|||
| # Backup entities generated with doctrine:generate:entities command | |||
| **/Entity/*~ | |||
| /.idea/ | |||
| /vendor/ | |||
There was a problem hiding this comment.
This is duplicated from line 30
| @@ -14,6 +14,8 @@ | |||
| !var/cache/.gitkeep | |||
| !var/logs/.gitkeep | |||
| !var/sessions/.gitkeep | |||
| !var/SymfonyRequirements.php | |||
| /.web-server-pid | |||
There was a problem hiding this comment.
This was added in another PR, and can be cleaned up after the merge conflict is resolved.
yuseferi
approved these changes
Jan 24, 2018
|
Closing due to inactivity. @jezemery let me know if there's anything unclear about the feedback I've provided, and if you're able to address those I'm happy to revisit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including additional rules recommended by Symfony and basic IDE rule
Reasons for making this change:
To better meet the requirements of Symfony
Links to documentation supporting these rule changes:
ERM?
If this is a new template:
N/A