Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove Composer's file and directory." #2513

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

lushc
Copy link

@lushc lushc commented Nov 9, 2017

This reverts commit 5b83681.

Reasons for making this change:

Symfony is installed with Composer [1], ignores vendors in the standard distribution's gitignore [2], and it's generally recommended to avoid committing the vendor directory [3]. Although #2312 states the reason for removal (duplicate rules), in my opinion, it's better to include them here also since users pushing a new Symfony project are far more likely to select this gitignore over the Composer one, given the fact it has more relevant rules and that you cannot choose multiple gitignores in the UI when creating a new repo. Additionally, users new to Symfony and/or Composer might not even be aware that you shouldn't be committing vendor files (which can grow into 100s of MB in size).

Links to documentation supporting these rule changes:

  1. http://symfony.com/doc/master/setup.html
  2. https://github.com/symfony/symfony-standard/blob/3.3/.gitignore#L16
  3. https://getcomposer.org/doc/faqs/should-i-commit-the-dependencies-in-my-vendor-directory.md

@shiftkey
Copy link
Member

@lushc thanks, those details help!

@shiftkey shiftkey merged commit f051f25 into github:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants