Add ignore rules for Pipenv #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipenv uses Pipfile.lock to maintain Python package information (metadata, hash, etc.) installed as described in Pipfile. Thus, Pipfile.lock may vary on different operating systems, platforms when collaborating. This PR adds Pipfile.lock into the Python default gitignore. See http://pipenv.org
|
According to the Pipenv docs and pypa/pipenv#598 it is generally recommended to add So -1 for adding it by default. |
Not to ignore Pipfile.lock in default, but explain when and why it should be ignored in case of collaboration. (adjusted according to comment in github#2977 by @drothmaler )
|
Noted. Adjusted according to @drothmaler 's comment. |
shiftkey
reviewed
Mar 8, 2019
Co-Authored-By: JarryShaw <jarryshaw@icloud.com>
As suggested by @shiftkey , elaborate on the problems that users might see with `Pipfile.lock`.
kiku-jw
pushed a commit
to kiku-jw/gitignore
that referenced
this pull request
Apr 6, 2019
* Add ignore rules for Pipenv Pipenv uses Pipfile.lock to maintain Python package information (metadata, hash, etc.) installed as described in Pipfile. Thus, Pipfile.lock may vary on different operating systems, platforms when collaborating. This PR adds Pipfile.lock into the Python default gitignore. See http://pipenv.org * Update Python.gitignore Not to ignore Pipfile.lock in default, but explain when and why it should be ignored in case of collaboration. (adjusted according to comment in github#2977 by @drothmaler ) * Apply suggestions from code review Co-Authored-By: JarryShaw <jarryshaw@icloud.com> * Update Python.gitignore As suggested by @shiftkey , elaborate on the problems that users might see with `Pipfile.lock`.
Ortega-Dan
pushed a commit
to Ortega-Dan/gitignore
that referenced
this pull request
Jun 26, 2019
* Add ignore rules for Pipenv Pipenv uses Pipfile.lock to maintain Python package information (metadata, hash, etc.) installed as described in Pipfile. Thus, Pipfile.lock may vary on different operating systems, platforms when collaborating. This PR adds Pipfile.lock into the Python default gitignore. See http://pipenv.org * Update Python.gitignore Not to ignore Pipfile.lock in default, but explain when and why it should be ignored in case of collaboration. (adjusted according to comment in github#2977 by @drothmaler ) * Apply suggestions from code review Co-Authored-By: JarryShaw <jarryshaw@icloud.com> * Update Python.gitignore As suggested by @shiftkey , elaborate on the problems that users might see with `Pipfile.lock`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipenv uses Pipfile.lock to maintain Python package information
(metadata, hash, etc.) installed as described in Pipfile. Thus,
Pipfile.lock may vary on different operating systems, platforms
when collaborating. This PR adds Pipfile.lock into the Python
default gitignore. See http://pipenv.org