Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Zend Framework 2 gitignore file #886

Merged
merged 6 commits into from

3 participants

@acelaya

Zend Framework 2 homepage is http://framework.zend.com/

I decided to include Zend Framework 2 gitignore because Zend Framework 1 file was already in this project.

Files included in gitignore are those meant to be excluded from version control, like local config files, dynamic binary folders like temp folders or binary gettext files, readmes, third party libraries and such.

None of this files are usually included to version control.

Alejandro Ce... added some commits
@aroben
Owner

Does this need to be a separate file, or can we just combine it with the existing ZendFramework.gitignore?

@acelaya

Directory structure is completly different in Zend Framework 1 projects and Zend Framework 2 projects, so I think is better to keep them separate.

@arcresu
Collaborator

I think it's a bit of a stretch to call them completely different when ZendFramework.gitignore contains only five rules, and three of them are essentially duplicated here :stuck_out_tongue_winking_eye: I think that they can go in the same template -- and is the first version even relevant any more?

I have a few objections/questions:

  • note that there is a template for composer, and it encodes the best practice of not ignoring the lock file
  • why is it considered good practice to ignore documentation files like README and INSTALL?
  • how strong is the guarantee that local config is truly local to one machine/developer?
  • why are there variations log/logs and temp/tmp? If they are well-known directories then shouldn't the name be consistent?
@acelaya

@arcresu you are right, documentation files and composer.lock shouldn't be ignored. I have updated it.
Logs and temporary folders do not really have standardized names, but I have only seen them with those two names.
Configuration files with the local keyword are considered development specific configuration files in ZF2 and are suposed to be ignored and never deployed to production.

@arcresu
Collaborator

Thanks for updating this! If you're in agreement about not ignoring documentation, then that should probably also apply to the existing ZendFramework.gitignore; once you take the doc rules out of that, all that's left is demos/. I think at this point it's safe to say that the old template isn't very useful. So I think you can delete the old template and drop the 2 from the name of this one. If you do that, I'd be happy to merge.

acelaya added some commits
@acelaya acelaya Removed old ZendFramework.gitignore
Documentation rules have been removed and the rest of the rules are going to be included in the ZendFramework2.gitignore.
d444178
@acelaya acelaya Included Zend Framework 1 rules 1d96081
@acelaya acelaya ZendFramework2.gitignore renamed to ZendFramework.gitignore ee1c7c0
@acelaya

@arcresu Done!
I have already included the demos/ rules in the new file

@arcresu
Collaborator

Thanks, looks good!

@arcresu arcresu merged commit 561bd5d into github:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 3, 2013
  1. Created Zend Framework 2 gitignore file

    Alejandro Celaya authored
  2. Included missing new line

    Alejandro Celaya authored
Commits on Apr 25, 2014
  1. @acelaya
Commits on May 11, 2014
  1. @acelaya

    Removed old ZendFramework.gitignore

    acelaya authored
    Documentation rules have been removed and the rest of the rules are going to be included in the ZendFramework2.gitignore.
  2. @acelaya
  3. @acelaya
This page is out of date. Refresh to see the latest.
Showing with 18 additions and 3 deletions.
  1. +18 −3 ZendFramework.gitignore
View
21 ZendFramework.gitignore
@@ -1,5 +1,20 @@
-INSTALL.txt
-LICENSE.txt
-README.txt
+# Composer files
+composer.phar
+vendor/
+
+# Local configs
+config/autoload/*local.php
+
+# Binary gettext files
+*.po
+
+# Data
+log/
+logs/
+cache/
+temp/
+tmp/
+
+# ZF1
demos/
extras/documentation
Something went wrong with that request. Please try again.