Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript conversion #30

Merged
merged 6 commits into from
Jun 3, 2020
Merged

TypeScript conversion #30

merged 6 commits into from
Jun 3, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented May 28, 2020

  • TypeScript
  • Remove UMD build
  • Start running tests on GitHub Actions
  • Upgrade dependencies including eslint-config-github
  • Remove Travis CI config
  • Add CODEOWNERS
  • Add an example page

@muan muan requested a review from a team May 28, 2020 20:35
dgraham
dgraham approved these changes Jun 2, 2020
View reviewed changes
.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
src/radix-trie.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
muan and others added 2 commits June 3, 2020 16:55
@muan @dgraham
Apply suggestions from code review
c997b75 
Co-authored-by: David Graham <dgraham@github.com>
@muan
Add return types
acbbce6
@muan muan merged commit 37e7b39 into master Jun 3, 2020
@muan muan deleted the ts branch June 3, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgraham dgraham dgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muan @dgraham