fix: Negative time reported for "time label applied" measurement #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding and fixing this bug! I'm able to take a look at this on Tuesday and plan to review then unless @jmeridth has time before then. |
|
Tested locally and confirmed fix works. Thank you @smstone On latest
Originally labelled:
Unlabelled:
Relabelled:
With fix
|
jmeridth
approved these changes
May 19, 2024
jmeridth
added a commit
that referenced
this pull request
May 19, 2024
Release fails if pull request is from a fork currently because we can't access the labels on the forked pull request which helps us determine semver for next release. Saw this after merging #283 (from a fork) Add pull_request_target to release action workflow I am not worried about the security implications with us checking out the forked pull requests code. This action only fires after a merge to main so this means the pull request code has been reviewed by a maintainer. We are post-CI/code run. Signed-off-by: jmeridth <jmeridth@gmail.com>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Address case where negative time for "time label applied" is reported for labels that have at some point been both "labeled" and "unlabeled" on a given issue (#282)
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreaking