Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Negative time duration for labels applied after issue close; Inflated metric numbers for unlabeled labels on open issues #287

Merged
merged 4 commits into from
May 21, 2024

Conversation

smstone
Copy link
Contributor

@smstone smstone commented May 20, 2024

Pull Request

I came across two additional issues in label time durations:

  1. Negative time durations metrics for issues where the label was applied after issue close.
  2. Inflated time durations for unlabeled issues where the issue is still open (I think I introduced the issue in fix: Negative time reported for "time label applied" measurement #283)

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@jmeridth
Copy link
Member

@smstone another great catch. Will look soon. Thank you for the contribution.

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good. Thank you @smstone.

@jmeridth jmeridth merged commit fbe4e7c into github:main May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants