Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 more JavaScript interpreters #4783

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Add 2 more JavaScript interpreters #4783

merged 2 commits into from
Jan 27, 2020

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Jan 25, 2020

This PR registers 4 2 more JavaScript interpreters:

Template removed as it doesn't really apply.


[1] Removed after discussion with @pchaigno

@Alhadis Alhadis requested a review from pchaigno January 25, 2020 09:40
@Alhadis
Copy link
Collaborator Author

Alhadis commented Jan 25, 2020

@lildude No idea what's going on with CI:

  1) Error:
TestRepository#test_linguist_override_detectable?:
Rugged::OdbError: object not found - no match for id (933c687cb8c02035394979b2308e5120a9904fdf)
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:128:in `lookup'
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:128:in `current_tree'
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:123:in `read_index'
    /home/runner/work/linguist/linguist/test/test_repository.rb:149:in `test_linguist_override_detectable?'

  2) Error:
TestRepository#test_linguist_override_unvendored?:
Rugged::OdbError: object not found - no match for id (933c687cb8c02035394979b2308e5120a9904fdf)
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:128:in `lookup'
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:128:in `current_tree'
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:123:in `read_index'
    /home/runner/work/linguist/linguist/test/test_repository.rb:108:in `test_linguist_override_unvendored?'

  3) Error:
TestRepository#test_linguist_override_documentation?:
Rugged::OdbError: object not found - no match for id (933c687cb8c02035394979b2308e5120a9904fdf)
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:128:in `lookup'
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:128:in `current_tree'
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:123:in `read_index'

  4) Error:
TestRepository#test_linguist_override_generated?:
Rugged::OdbError: object not found - no match for id (933c687cb8c02035394979b2308e5120a9904fdf)
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:128:in `lookup'
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:128:in `current_tree'
    /home/runner/work/linguist/linguist/lib/linguist/repository.rb:123:in `read_index'
    /home/runner/work/linguist/linguist/test/test_repository.rb:137:in `test_linguist_override_generated?'

1330 runs, 26783 assertions, 0 failures, 4 errors, 0 skips
rake aborted!
Command failed with status (1)

Pretty sure it has nothing to do with this PR, though. 😉

Alhadis added a commit to Alhadis/JG that referenced this pull request Jan 25, 2020
@Alhadis Alhadis changed the title Add 4 more JavaScript interpreters Add 2 more JavaScript interpreters Jan 25, 2020
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis CI build failures seem related to the test-attributes branch and not this pull request.

/cc @lildude

@SiAdcock SiAdcock mentioned this pull request Jan 25, 2020
2 tasks
@lildude
Copy link
Member

lildude commented Jan 26, 2020

Travis CI build failures seem related to the test-attributes branch and not this pull request.

Oh 💩 🤦‍♂ I squash merged that branch PR which added that SHA which means the SHA got stomped all over. Fix coming.

@lildude lildude merged commit 9e70f4d into master Jan 27, 2020
@lildude lildude deleted the more-js-engines branch January 27, 2020 06:14
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants