-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
headings not rendering anymore #1013
Comments
Hi David! This is related to our move to CommonMark for markdown rendering: https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown CommonMark requires that there be a space between the |
Righto thank you
…On Fri, 17 Mar 2017, 00:44 Shawna Jean ***@***.***> wrote:
Closed #1013 <#1013>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1013 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATa6xG7at1ech_fYcZ1sH3Hmj49icCCks5rmTy9gaJpZM4MfAFZ>
.
|
GitHub recently updated their Markdown renderer to require a space between the `#` characters and the title of a header. See here for details: github/markup#1013 This change was made by running: sed --in-place 's/^\(##*\)\([^# ]\)/\1 \2/' README.md
GitHub recently updated their Markdown renderer to require a space between the `#` characters and the title of a header. See here for details: github/markup#1013 This change was made by running: sed --in-place 's/^\(##*\)\([^# ]\)/\1 \2/' README.markdown
GitHub recently updated their Markdown renderer to require a space between the `#` characters and the title of a header. See here for details: github/markup#1013 This change was made by running: sed --in-place 's/^\(##*\)\([^# ]\)/\1 \2/' README.md
Just doing this to create a new push to try and get the front page Readme to render properly again. According to github/markup#1013 this should fix the rendering.
Just doing this to create a new push to try and get the front page Readme to render properly again. According to github/markup#1013 this should fix the rendering.
As per github/markup#1013 a space between the hashtag and text is *required* so I just put it in real quick.
a github update made it so you need to add a space in between your pound sign and the text in order for markdown to parse correctly. more info here: github/markup#1013
Found this issue on most of my readme pages. I wish github had proactively conveyed this to users about their broken pages and a need for fix. |
This completely defeats the purpose of Markdown. What possible reason could there be for imposing this absurd restriction? |
Requires a space between the hash and the heading markup. This conforms to the CommonMark spec and is necessary for Github compatibility. See: - github/markup#1013 (comment) - https://blog.github.com/2017-03-14-a-formal-spec-for-github-flavored-markdown/
As was stated in this other issue, the markup gem doesn't control GitHub's Markdown rendering. Since this is off-topic for this repo, I'm going to lock this issue. If you have questions about GitHub's Markdown rendering, please reach out to the support team. |
In the last couple of days github markdown rendering has stopped rendering headings without delimiting spaces:
This used to render fine:
but now has to be:
Was this a deliberate move? You'd have to consider it a major breaking change!
The text was updated successfully, but these errors were encountered: