Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --[no-]use-lcs #227

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Add --[no-]use-lcs #227

merged 1 commit into from
Jan 13, 2021

Conversation

nbarrientos
Copy link
Contributor

Add a CLI option (--[no-]use-lcs) so the usage of the LCS algo when comparing arrays can be switched on and off. The default is to keep it on as it's has been so far.

Closes #207

@ahayworth ahayworth closed this Dec 15, 2020
@ahayworth ahayworth reopened this Dec 15, 2020
@ahayworth
Copy link
Contributor

Hey @nbarrientos , the PR is out of date with master but I don't seem to have permissions to update the PR. Can you merge master?

@ahayworth ahayworth added this to the 2.0.0 milestone Dec 17, 2020
@ahayworth ahayworth removed this from the 2.0.0 milestone Jan 12, 2021
Add a CLI option (--[no-]use-lcs) so the usage of the LCS algo when
comparing arrays can be switched on and off. The default is to keep it
on as it's has been so far.

Closes github#207
@nbarrientos
Copy link
Contributor Author

Rebased.

Copy link
Contributor

@ahayworth ahayworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic - this looks great. Thank you!

@ahayworth ahayworth added this to the 2.1.0 milestone Jan 13, 2021
@ahayworth ahayworth merged commit 089b699 into github:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider not using LCS by default or allow switching it off
2 participants