Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EquivalentArrayNoDatatypes filter #254

Merged

Conversation

kpaulisse
Copy link
Contributor

Overview

This pull request adds a new filter called EquivalentArrayNoDatatypes which suppresses diffs like this one:

  Exec[my-command-here] =>
   parameters =>
     returns =>
      - ["0", "1"]
      + [0, 1]

Specifically, this implementation treats the string, integer, and float values of a given number as the same ("1" == 1 == 1.0) and treats the string representation of a symbol as the same as the string (":foo" == :foo).

Unit tests are updated to cover this filter and an integration test has been added. Filter documentation has also been updated.

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.

@kpaulisse kpaulisse force-pushed the kpaulisse-equivalent-array-filter branch from 56c1228 to c58ff56 Compare June 14, 2021 16:56
Copy link
Contributor

@ahayworth ahayworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me! Thank you! 😄

@ahayworth ahayworth merged commit 5071b97 into github:master Jul 2, 2021
@kpaulisse kpaulisse deleted the kpaulisse-equivalent-array-filter branch August 23, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants