Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version lock from html-proofer #3214

Merged
merged 4 commits into from
May 23, 2024
Merged

Remove version lock from html-proofer #3214

merged 4 commits into from
May 23, 2024

Commits on Apr 29, 2024

  1. Remove version lock from html-proofer

    There have been 2 major revs of HTML-Proofer since the one
    we pinned. The current one is causing flaky tests - it's missing
    clear errors w/internal links and only reports the first
    error it finds rather than running to completion and reporting
    all of them.
    
    The latest version (5.0.8 at the moment) does catch all of the
    errors but has a problem locally where UTF-8 encoded anchor links
    are not properly decoded. This might be a problem local to me though;
    I coded up a spec test in html-proofer with an exact copy-paste
    of one of the failing links and ... it passes there.
    
    So i'll unpin this and see if there's some local gem issue that's
    causing this on my machine and maybe it works in the Actions env.
    ahpook committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7d2578b View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Bump ruby-version to 3.2.x

    ahpook committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    81f75fb View commit details
    Browse the repository at this point in the history
  2. Update html-proofer config stanza for new version

    based on html-proofer's UPGRADING.md , many of the old configuration directives have changed names in the new version.
    ahpook committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0c42faa View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Configuration menu
    Copy the full SHA
    2fd1657 View commit details
    Browse the repository at this point in the history