Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous grammar and style fixes #36

Merged
merged 6 commits into from
Aug 17, 2016
Merged

Miscellaneous grammar and style fixes #36

merged 6 commits into from
Aug 17, 2016

Conversation

wooorm
Copy link
Contributor

@wooorm wooorm commented Aug 17, 2016

I read the guide for the second time today and found a tiny few small things. First of all: it’s already really well written, so I didn’t have much to add

  • I found some double spaces (cda4d7f).
  • Mostly the Oxford comma was used, there were two cases without it though (7dc2322);
  • Casing: The only thing I found was Internet vs. internet. Both occurred twice. I opted for the latter but can also go with the former if need be (ee2fc4a);
  • Typo’s: I found one duplicate your your, one ,,, a weird plural, and a missing space (801896a);
  • Mostly singular they was used, except for a few cases. I replaces some cases of him/her with them etc. Oh, there was also an execution, which isn’t really bad per se but I opted for implementation instead (5bc3eda).

Again, really well written, not much to add! 👍

Oh, and finally, not sure whether y’all prefer more squashing, or less squashing. I normally squash everything into one commit but I think GH prefers multiple commits? Hope this is ok!

* More singular they;
* general sensitivity.
Only word I found: two cases of `Internet`, two of `internet`,
I went with `internet` but could reverse it just as well.
@wooorm wooorm added the content label Aug 17, 2016
Copy link

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions re pronouns, but 👍 either way.

@@ -18,7 +18,7 @@

* Wants people to notice their project

* Wants people to actually use the project, give him/her feedback
* Wants people to actually use the project, give them feedback

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing this to avoid using a pronoun?

  • Wants people to actually use the project and give feedback

@@ -42,7 +42,7 @@

### Primary Goals

* Manage personal time so project demands don’t overwhelm him/her
* Manage personal time so project demands don’t overwhelm them

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion here:

  • Manage personal time so project demands don’t become overwhelming

@bkeepers
Copy link

  • I found some double spaces (cda4d7f).
  • Mostly the Oxford comma was used, there were two cases without it though (7dc2322);

Suggestions on how we could add lint checks for these?

@wooorm
Copy link
Contributor Author

wooorm commented Aug 17, 2016

Thought of that as well. I applied some regex-fu, so it’s very much programmable. I’d say separate retext plugins. The first makes a very good example for a guide on how to use retext!

The second is a bit harder, the whole reason Oxfords should be used is because if they aren’t, they’re ambiguous to humans, so a computer will also show false-positives 😬

@wooorm
Copy link
Contributor Author

wooorm commented Aug 17, 2016

Your suggestions: even better! Added!

@bkeepers
Copy link

Oh, and finally, not sure whether y’all prefer more squashing, or less squashing. I normally squash everything into one commit but I think GH prefers multiple commits? Hope this is ok!

I tend to prefer separate commits, but am not opinionated about it. We don't have any contribution guidelines here yet, so anything goes. 👐

@wooorm
Copy link
Contributor Author

wooorm commented Aug 17, 2016

screen shot 2016-08-17 at 23 52 33

I’ll add some tests first, send a separate PR later 👍

Copy link
Contributor

@nayafia nayafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching all these errors! much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants