Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Maruku 0.7.2 #77

Closed
wants to merge 1 commit into from
Closed

Conversation

bhollis
Copy link

@bhollis bhollis commented Jul 8, 2014

Maruku has had two maintenance releases since 0.7.0: https://github.com/bhollis/maruku/blob/master/CHANGELOG.md

These are backwards-compatible bugfix releases.

@parkr
Copy link
Contributor

parkr commented Jul 6, 2014

0.7.1 was not backwards-compatible IIRC (or introduced new bugs) but let's give 0.7.2 a try. Would you mind submitting a PR with the necessary changes?

@bhollis
Copy link
Author

bhollis commented Jul 8, 2014

I've converted this to a pull request. I didn't see any tests that would verify that this new version works the way you'd expect, though - if you have those, let me know and I'll run them.

In the future, if you have problems with Maruku (backwards incompatibilities, bugs) please file issues at https://github.com/bhollis/maruku/issues so we can address them. The intention is for Maruku to follow semver, modulo changes to output caused by fixing broken behavior.

@bhollis
Copy link
Author

bhollis commented Jul 8, 2014

Looks like I'll also have to file a PR to Jekyll because they locked to a specific minor version.

@thomasjo
Copy link

thomasjo commented Jul 8, 2014

This PR needs to be applied to the jekyll-2-1 branch.

@bhollis
Copy link
Author

bhollis commented Jul 8, 2014

jekyll/jekyll#2576

@bhollis
Copy link
Author

bhollis commented Jul 8, 2014

@thomasjo unfortunately I cannot change the target branch of a PR once filed. Would you like me to file a new PR?

@thomasjo
Copy link

thomasjo commented Jul 8, 2014

@bhollis Nah, should be fine as long as the PR is applied with git-am or similar. I'm sure @parkr will sort it out.

@benbalter
Copy link
Contributor

Still interested in the bump? Jekyll-2-1 is now master

parkr added a commit that referenced this pull request Jul 31, 2014
@parkr parkr mentioned this pull request Jul 31, 2014
@parkr
Copy link
Contributor

parkr commented Jul 31, 2014

I've done this in #82.

@parkr parkr closed this Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants