New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maruku dependency to allow use of the latest version #2576

Merged
merged 1 commit into from Jul 10, 2014

Conversation

Projects
None yet
4 participants
@bhollis
Contributor

bhollis commented Jul 8, 2014

All Maruku releases post-0.6 follow semver, so they should be backwards-compatible on minor versions. In this case, the only test that needed to change was one that was asserting buggy behavior that was fixed in 0.7.1.

@bhollis bhollis referenced this pull request Jul 8, 2014

Closed

Upgrade to Maruku 0.7.2 #77

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 8, 2014

Member

Looks like there are some test failures due to change in behaviour for the latest Maruku.

From my understanding of SemVer, and version pre-1.0, should be locked to PATCH level variation, thus ~> 0.7.0 would be most appropriate.

Member

parkr commented Jul 8, 2014

Looks like there are some test failures due to change in behaviour for the latest Maruku.

From my understanding of SemVer, and version pre-1.0, should be locked to PATCH level variation, thus ~> 0.7.0 would be most appropriate.

@bhollis

This comment has been minimized.

Show comment
Hide comment
@bhollis

bhollis Jul 9, 2014

Contributor

My bad - you're right, we should require ~> 0.7.0. As for the test failures, I just ran be rake test and missed the cucumber tests, I'll fix them now. All the failures you're seeing are due to a regression in 0.7.0 that was fixed in 0.7.1, but the jekyll tests got updated to assert the bad behavior.

Contributor

bhollis commented Jul 9, 2014

My bad - you're right, we should require ~> 0.7.0. As for the test failures, I just ran be rake test and missed the cucumber tests, I'll fix them now. All the failures you're seeing are due to a regression in 0.7.0 that was fixed in 0.7.1, but the jekyll tests got updated to assert the bad behavior.

Update Maruku dependency to allow use of the latest version.
All Maruku releases post-0.6 follow semver, so they should be backwards-compatible on minor versions. In this case, the only test that needed to change was one that was asserting buggy behavior that was fixed in 0.7.1.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 9, 2014

Member

Cool, thanks! This LGTM. @benbalter, any final thoughts?

Member

parkr commented Jul 9, 2014

Cool, thanks! This LGTM. @benbalter, any final thoughts?

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Jul 9, 2014

Contributor

:shipit: Thanks @bhollis!

Contributor

benbalter commented Jul 9, 2014

:shipit: Thanks @bhollis!

@parkr parkr added the :shipit: label Jul 9, 2014

@parkr parkr self-assigned this Jul 9, 2014

parkr added a commit that referenced this pull request Jul 10, 2014

@parkr parkr merged commit ece2249 into jekyll:master Jul 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jul 10, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.