Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated require-jira-issue.sh #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated require-jira-issue.sh #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pre-receive-hooks/require-jira-issue.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
set -e

zero_commit='0000000000000000000000000000000000000000'
msg_regex='[JIRA\-[0-9]+\]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeeprayala: as you noticed, minus is a special character, so we escaped it to match it as a literal. Your suggested change is to remove that escaping. Have you tested your change? Are you saying that the script did not work for you before?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have tested and it worked for me, my suggestion is to remove the " [ ] "'.

once you remove the square brackets the regex would be as below.
msg_regex= 'JIRA-[0-9]+'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree; this regex is a mess. The first [ is unescaped, which makes the rest act as a set that goes up to the closing ] after the 9.

I set up an example here with a full explanation - https://regex101.com/r/R6kCL6/1

This broken regex will incorrectly match:

  • JIRA-99]
  • 0]
  • -]

The outer brackets should be escaped or totally removed depending on the author's intent.

msg_regex='JIRA-[0-9]+'

while read -r oldrev newrev refname; do

Expand Down