This repository has been archived by the owner on May 5, 2020. It is now read-only.
CVE-2013-6415: Escape the unit value provided to number_to_currency #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CVE-2013-6415. Previously the values were trusted blindly allowing for potential XSS attacks. This is different from the original upstream patch for 3.x in that return values from other number helper methods are not marked as html_safe, so the html escaping always applies. This requires applications to explicitly set .html_safe on unit strings and number separators when calling number_to_currency.
|
Looks good to me. |
|
👍 |
|
|
zerowidth
added a commit
that referenced
this pull request
Dec 3, 2013
CVE-2013-6415: Escape the unit value provided to number_to_currency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CVE-2013-6415.
Previously the values were trusted blindly allowing for potential XSS attacks.
This is different from the original upstream patch for 3.x: return values from other number helper methods are not marked as
html_safe?, so the html escaping always applies. This requires applications to explicitly call.html_safeon unit strings and number separators when callingnumber_to_currency.