Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Updating a PR doesn't trigger rally check #234

Closed
forevergenin opened this issue Feb 10, 2021 · 3 comments · Fixed by #246
Closed

Updating a PR doesn't trigger rally check #234

forevergenin opened this issue Feb 10, 2021 · 3 comments · Fixed by #246
Assignees
Labels
bug Something isn't working O: backlog 🤖 Exempt from stale bot

Comments

@forevergenin
Copy link

This one is similar to #161 but of more generic nature.

Bug Description

Updating a PR with new commits or amended commits doesn't trigger new rally check and drops any current failed checks as well.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new PR with invalid/missing rally information
  2. The rally check will run and fail
  3. Updated the PR with additional new commits or amended commits
  4. The current checks are cleared and rally check is not re-triggered.

Expected behavior

Expected behavior is for rally checks to re-trigger and fail again

@forevergenin forevergenin added the bug Something isn't working label Feb 10, 2021
@forevergenin
Copy link
Author

Adding pull_request.synchronize to the list of web hooks to listen to trigger rally check might fix this issue.

https://github.community/t/what-is-a-pull-request-synchronize-event/14784/4
https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request

@zkoppert zkoppert added the O: backlog 🤖 Exempt from stale bot label Mar 15, 2021
@zkoppert
Copy link
Member

zkoppert commented Mar 17, 2021

I was able to reproduce this behavior.

@zkoppert
Copy link
Member

Working on testing if pull_request.synchronize addresses this issue. Work being done on the multi-commit branch.

@zkoppert zkoppert self-assigned this Mar 17, 2021
@zkoppert zkoppert mentioned this issue Mar 17, 2021
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working O: backlog 🤖 Exempt from stale bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants