Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Add pull.sync trigger #246

Merged
merged 5 commits into from
Mar 25, 2021
Merged

Add pull.sync trigger #246

merged 5 commits into from
Mar 25, 2021

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Mar 17, 2021 •
edited
Loading

Fixes #161
Fixes #234

Proposed Changes

  • trigger a rerun of the check when a new commit is detected

Readiness Checklist

  • If this change requires documentation, it has been included in this pull request

Reviewer Checklist

  • If a functional change has occurred, testing the integration has been performed
  • This PR has been categorized with a label (1 of automation, bug, documentation, enhancement, infrastructure, or performance) for the changelog

@zkoppert zkoppert self-assigned this Mar 17, 2021
@zkoppert zkoppert added the bug Something isn't working label Mar 17, 2021
@zkoppert zkoppert changed the title Add pull.sync trigger WIP: Add pull.sync trigger Mar 17, 2021
@zkoppert
Copy link
Member Author

In the testing phase to see if this will work as intended.

@zkoppert zkoppert marked this pull request as ready for review March 23, 2021 23:27
@zkoppert
Copy link
Member Author

I was able to complete testing with this change and it does in fact now check subsequent commits.
Screen Shot 2021-03-23 at 4 29 08 PM

This PR is now ready for review.

@zkoppert zkoppert changed the title WIP: Add pull.sync trigger Add pull.sync trigger Mar 24, 2021
primetheus
primetheus approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@primetheus primetheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@zkoppert zkoppert merged commit 61c1b0f into main Mar 25, 2021
@zkoppert zkoppert deleted the multi-commit branch March 25, 2021 02:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@primetheus primetheus primetheus approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@migarjo migarjo Awaiting requested review from migarjo

@steffen steffen Awaiting requested review from steffen

Assignees

@zkoppert zkoppert

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating a PR doesn't trigger rally check multiple commit messages
2 participants
@zkoppert @primetheus