Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

multiple commit messages #161

Closed
vader2890 opened this issue Oct 19, 2020 · 2 comments · Fixed by #246
Closed

multiple commit messages #161

vader2890 opened this issue Oct 19, 2020 · 2 comments · Fixed by #246
Assignees
Labels
bug Something isn't working good first issue Good for newcomers O: backlog 🤖 Exempt from stale bot

Comments

@vader2890
Copy link

Your issue may already be reported!
Please search on the issue tracker before creating one.

Describe the bug
If a pull request has multiple commits/commit messages , the check fails to run

To Reproduce
Steps to reproduce the behavior:

  1. Create a PR
  2. rally.yml must have the commit message validation checked
  3. Click on the checks
  4. Checks does not run when PR has multiple commit messages

Expected behavior
Checks must be run for all commit messages

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@vader2890 vader2890 added the bug Something isn't working label Oct 19, 2020
@primetheus
Copy link
Contributor

@vader2890 thanks for opening this up! I'll work on reproducing it and get a fix out shortly 🙇🏽

@primetheus primetheus added good first issue Good for newcomers O: backlog 🤖 Exempt from stale bot labels Oct 27, 2020
@primetheus primetheus self-assigned this Oct 27, 2020
@forevergenin
Copy link

This bug is seen when the PR is updated with additional commits after the initial commit.

Steps to reproduce issue.

  1. Create a PR with one commit and invalid commit id in commit message/description/pr title
  2. The PR checks will fail because of invalid/missing rally information
  3. Update the PR with additional commit messages - new commit messages shouldn't have valid user story id.

After the step 3 expected behavior is to have trigger check and mark it as failed but the the current behavior is PR is marked as ready for merge and the previous checks are resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers O: backlog 🤖 Exempt from stale bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants