Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add define static method #257

Merged
merged 1 commit into from Apr 18, 2023
Merged

add define static method #257

merged 1 commit into from Apr 18, 2023

Conversation

keithamus
Copy link
Member

This makes a few small tweaks to how we define elements.

It adds a define() static member to the RelativeTimeElement class, which allows changing of tag/registry. It calls that method in the relative-time-element-define file.

This also exports the class as both named and default exports. We may drop the default export at a future date.

@keithamus keithamus requested a review from a team as a code owner April 18, 2023 10:57
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@keithamus keithamus merged commit a3f2192 into main Apr 18, 2023
1 check failed
@keithamus keithamus deleted the add-define-static-method branch April 18, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants