-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome Headless, eslint upgrade, npm scripts #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
browsers: ['ChromeHeadless'], | ||
autoWatch: false, | ||
singleRun: true, | ||
concurrency: Infinity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…and beyond! ✊
test/karma.config.js
Outdated
config.set({ | ||
frameworks: ['mocha', 'chai'], | ||
files: [ | ||
'../dist/time-elements.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to load the "legacy" file for tests, now we load the main one. I suspect this was because PhantomJS was unable to handle the non-legacy build.
However, if we load this test suite in an older browser, such as IE 11, would it work with this configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I don't think it would. Since the legacy file is the main file on the module, I have changed this here to test with the legacy build instead.
.travis.yml
Outdated
@@ -1,5 +1,2 @@ | |||
language: node_js | |||
node_js: 6.9.1 # latest LTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting this to "node" will give us the latest version.
node_js:
- "node"
.travis.yml
Outdated
@@ -1,5 +1,2 @@ | |||
language: node_js | |||
node_js: 6.9.1 # latest LTS | |||
cache: | |||
directories: | |||
- node_modules/phantomjs-prebuilt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can cache the node_modules/
directory.
https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Caching-with-npm
💚 https://travis-ci.org/github/time-elements/builds/316327437
cc @github/web-systems